Skip to content

new items in the usage report #18927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Jul 7, 2025

Problem Statement

Adding items from SAT-30441 and from
theforeman/foreman_maintain#986 that went trough without jira but passed revies

Solution

Related Issues

@pondrejk pondrejk self-assigned this Jul 7, 2025
@pondrejk pondrejk added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 7, 2025
@pondrejk
Copy link
Contributor Author

pondrejk commented Jul 7, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_usage_report.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11988
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_usage_report.py --external-logging
Test Result : ================== 1 failed, 7 warnings in 1117.61s (0:18:37) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 7, 2025
@pondrejk
Copy link
Contributor Author

pondrejk commented Jul 7, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_usage_report.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11990
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_usage_report.py --external-logging
Test Result : ================== 1 passed, 7 warnings in 1150.84s (0:19:10) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jul 7, 2025
Comment on lines +2 to +10
custom_alternate_content_sources_count: 0
simplified_alternate_content_sources_count: 0
rhui_alternate_content_sources_count: 0
yum_alternate_content_sources_count: 0
file_alternate_content_sources_count: 0
custom_library_yum_repositories_count: 0
redhat_library_yum_repositories_count: 0
library_debian_repositories_count: 0
library_container_repositories_count: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this file is used for usage report tests which is maintained by team-endeavour, how about we add this to CODEOWNERS to request review from team-endeavour ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it, though I'm not sure these files are meant to be reviewed, I don't see any other item from the data folder in CODEOWNERS. This file is just a dump from a fresh satellite for the test to compare against, and I suppose any further changes in this file will just be replacing it with a different dump

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I’m not sure what I should be reviewing here 🙂. If this PR doesn’t require a review from any of the reviewers, then who would be the right person or team to review and merge it?

However, I still believe it’s better to have the relevant owners assigned to the file so that any future changes trigger notifications to the respective team. We should ideally proceed with the merge only after the concerned team has ACK'd the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gauravtalreja1 fair point, there's no harm in doing that, I added the codeowners entry

@pondrejk pondrejk requested a review from a team as a code owner July 9, 2025 08:08
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants