-
Notifications
You must be signed in to change notification settings - Fork 125
new items in the usage report #18927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
trigger: test-robottelo |
PRT Result
|
trigger: test-robottelo |
PRT Result
|
custom_alternate_content_sources_count: 0 | ||
simplified_alternate_content_sources_count: 0 | ||
rhui_alternate_content_sources_count: 0 | ||
yum_alternate_content_sources_count: 0 | ||
file_alternate_content_sources_count: 0 | ||
custom_library_yum_repositories_count: 0 | ||
redhat_library_yum_repositories_count: 0 | ||
library_debian_repositories_count: 0 | ||
library_container_repositories_count: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this file is used for usage report tests which is maintained by team-endeavour, how about we add this to CODEOWNERS to request review from team-endeavour ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do it, though I'm not sure these files are meant to be reviewed, I don't see any other item from the data folder in CODEOWNERS. This file is just a dump from a fresh satellite for the test to compare against, and I suppose any further changes in this file will just be replacing it with a different dump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I’m not sure what I should be reviewing here 🙂. If this PR doesn’t require a review from any of the reviewers, then who would be the right person or team to review and merge it?
However, I still believe it’s better to have the relevant owners assigned to the file so that any future changes trigger notifications to the respective team. We should ideally proceed with the merge only after the concerned team has ACK'd the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gauravtalreja1 fair point, there's no harm in doing that, I added the codeowners entry
Problem Statement
Adding items from SAT-30441 and from
theforeman/foreman_maintain#986 that went trough without jira but passed revies
Solution
Related Issues