-
Notifications
You must be signed in to change notification settings - Fork 125
more fine-grained reporting tests #18951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
trigger: test-robottelo |
PRT Result
|
""" | ||
Runs satellite-maintain report generate and extracts the value for a given key | ||
""" | ||
result = self.execute(f'satellite-maintain report generate | grep -i "{report_key}"') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this command to robottelo CLI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that and used this form in the usage_report module_generate_report fixture, but for this case I'd like to filter only a selected part of it, grepping on the machine seems to me as a more effective way
robottelo/cli/sm_report.py
Outdated
from robottelo.cli.base import Base | ||
|
||
|
||
class Report(Base): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't people mistake this with report template report generation? Because I did when I saw module_target_sat.cli.Report.generate({'output': filename})
:)
robottelo/cli/sm_report.py
Outdated
|
||
@classmethod | ||
def generate(cls, options=None, env_var=None): | ||
"""Build satellite-maintain service start""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is some copy-paste leftover
Runs satellite-maintain report generate and extracts the value for a given key | ||
""" | ||
result = self.execute(f'satellite-maintain report generate | grep -i "{report_key}"') | ||
assert result.status == 0, 'key not found in the report' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or the report itself may have failed, the message may be misleading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overally LGTM, pending comments
Problem Statement
related to SAT-30441
Solution
Related Issues