Skip to content

Conversation

jeremylenz
Copy link
Contributor

@jeremylenz jeremylenz commented Oct 9, 2025

Katello PR: Katello/katello#11526

All organizations are now SCA (Simple Content Access) by default, making these
options irrelevant:

Core library changes:

  • Removed robottelo/cli/host.py subscription_auto_attach() method
  • Removed robottelo/hosts.py auto_attach parameter from register_contenthost()
  • Removed robottelo/cli/simple_content_access.py CLI wrapper module
  • Removed robottelo/host_helpers/satellite_mixins.py is_sca_mode_enabled() helper

Test changes:

  • Removed auto-attach tests from activation key test files (API and CLI)
  • Removed auto-attach test from host test file
  • Removed auto-attach from subscription/upgrade tests
  • Removed simple_content_access read check from test_subscription.py

Fixture changes:

  • Removed auto_attach parameter from activation key fixtures
  • Removed simple_content_access parameter from manifest fixtures

Data file changes:

  • Removed auto-attach/autoheal options from hammer_commands.json
  • Removed autoheal from test_hammer.py test expectations
  • Removed auto_attach API endpoints from test_api_endtoend.py

Configuration changes:

  • Removed SIMPLE_CONTENT_ACCESS settings from manifest.yaml.template

Problem Statement

Solution

Related Issues

All organizations are now SCA (Simple Content Access) by default, making these
options irrelevant:

Core library changes:
- Removed robottelo/cli/host.py subscription_auto_attach() method
- Removed robottelo/hosts.py auto_attach parameter from register_contenthost()
- Removed robottelo/cli/simple_content_access.py CLI wrapper module
- Removed robottelo/host_helpers/satellite_mixins.py is_sca_mode_enabled() helper

Test changes:
- Removed auto-attach tests from activation key test files (API and CLI)
- Removed auto-attach test from host test file
- Removed auto-attach from subscription/upgrade tests
- Removed simple_content_access read check from test_subscription.py

Fixture changes:
- Removed auto_attach parameter from activation key fixtures
- Removed simple_content_access parameter from manifest fixtures

Data file changes:
- Removed auto-attach/autoheal options from hammer_commands.json
- Removed autoheal from test_hammer.py test expectations
- Removed auto_attach API endpoints from test_api_endtoend.py

Configuration changes:
- Removed SIMPLE_CONTENT_ACCESS settings from manifest.yaml.template
@jeremylenz jeremylenz requested review from a team as code owners October 9, 2025 19:40
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jeremylenz
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py -k test_positive_installed_products
Katello: {katello: 11526}

@jeremylenz jeremylenz added the No-CherryPick PR doesnt need CherryPick to previous branches label Oct 9, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 13098
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_reporttemplates.py -k test_positive_installed_products --external-logging
Test Result : ========== 3 failed, 46 deselected, 88 warnings in 1764.73s (0:29:24) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants