Use deploy-satellite-iop workflow for module_satellite_iop fixture

[tpapaioa]

Problem Statement

The module_satellite_iop fixture should use the new deploy-satellite-iop AAP workflow

Solution

Update the fixture to use the workflow defined in the server.deploy_workflows.iop setting.

Related Issues

[tpapaioa]

trigger: test-robottelo
pytest: tests/foreman/ui/test_rhcloud_iop.py::test_iop_recommendations_e2e[rhel9-ipv4-local]
env:
  ROBOTTELO_SERVER__DEPLOY_WORKFLOWS__IOP: deploy-satellite-iop

[Satellite-QE]

PRT Result

Build Number: 13237
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_rhcloud_iop.py::test_iop_recommendations_e2e[rhel9-ipv4-local] --external-logging
Test Result : ================= 1 passed, 15 warnings in 2175.71s (0:36:15) ==================

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Wrap your teardown and Broker.checkin calls in a finalizer (or try/finally) so cleanup always runs even if the IoP assertion or a downstream error fails.
• Consider moving the IoP‐enabled assertion out of the fixture and into the tests themselves to keep fixtures focused on setup/teardown.
• Verify that any tests relying on the old module_unconfigured_satellite fixture are updated to use the new satellite_factory signature to prevent fixture resolution errors.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Wrap your teardown and Broker.checkin calls in a finalizer (or try/finally) so cleanup always runs even if the IoP assertion or a downstream error fails.
- Consider moving the IoP‐enabled assertion out of the fixture and into the tests themselves to keep fixtures focused on setup/teardown.
- Verify that any tests relying on the old module_unconfigured_satellite fixture are updated to use the new satellite_factory signature to prevent fixture resolution errors.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}