[6.18.z] Fix generating of hostname prefix

[Satellite-QE]

Cherrypick of PR: #20007

Test test_positive_update_hostname_default_prefix failed (semi)randomly. The failures were caused by invalid characters in the hostname prefix that is generated by generate_strings_list.
Allowed characters are following:
Value must start with a letter. Allowed characters: a-z, A-Z, 0-9 and -. Max length is 62 characters.
This fix generates string that meets this requirement.

[Satellite-QE]

trigger: test-robottelo
pytest: tests/foreman/api/test_settings.py -k 'test_positive_update_hostname_default_prefix'

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Satellite-QE]

PRT Result

Build Number: 13214
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_settings.py -k test_positive_update_hostname_default_prefix --external-logging
Test Result : =========== 1 failed, 26 deselected, 5 warnings in 702.84s (0:11:42) ===========

[lpramuk]

PRT failed with NameError: name 'gen_string' is not defined

You need to introduce the following import in 6.18.z branch:

from fauxfactory import gen_string

[rmynar]

Seems like the missing import is caused by not cherrypicking #19489
The cherrypick now exists: #20043
Let's wait for it to be merged and then rebase

[rmynar]

trigger: test-robottelo
pytest: tests/foreman/api/test_settings.py -k 'test_positive_update_hostname_default_prefix'

[Satellite-QE]

PRT Result

Build Number: 13248
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_settings.py -k test_positive_update_hostname_default_prefix --external-logging
Test Result : =========== 1 passed, 26 deselected, 5 warnings in 818.19s (0:13:38) ===========