-
Notifications
You must be signed in to change notification settings - Fork 127
[IOP] Add test for remediation type and status #20015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[IOP] Add test for remediation type and status #20015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `tests/foreman/ui/test_rhcloud_iop.py:319-320` </location>
<code_context>
+ assert len(result) > 0
+
+ # Verify that Disabled recommnedations are 0
+ result = session.recommendationstab.apply_filter("Status", "Disabled")
+ assert 'No recommendations' in result[0]['Name']
</code_context>
<issue_to_address>
**suggestion (testing):** Test assumes 'No recommendations' is always present for disabled status.
If zero recommendations are reported differently in the future, this assertion could break. Consider updating the test to handle both 'No recommendations' and an empty result list for greater robustness.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
result = session.recommendationstab.apply_filter("Status", "Disabled") | ||
assert 'No recommendations' in result[0]['Name'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Test assumes 'No recommendations' is always present for disabled status.
If zero recommendations are reported differently in the future, this assertion could break. Consider updating the test to handle both 'No recommendations' and an empty result list for greater robustness.
|
Test looks good overall, pending PRT. Please look into the component naming @ColeHiggins2. |
Tests for remediation type and status
SAT-32566
SatelliteQE/airgun#2163