Skip to content

Conversation

ColeHiggins2
Copy link
Member

Tests for remediation type and status
SAT-32566
SatelliteQE/airgun#2163

@ColeHiggins2 ColeHiggins2 self-assigned this Oct 17, 2025
@ColeHiggins2 ColeHiggins2 added RFE Issues that are requesting an enhancement to robottelo CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.18.z Introduced in or relating directly to Satellite 6.18 labels Oct 17, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `tests/foreman/ui/test_rhcloud_iop.py:319-320` </location>
<code_context>
+        assert len(result) > 0
+
+        # Verify that Disabled recommnedations are 0
+        result = session.recommendationstab.apply_filter("Status", "Disabled")
+        assert 'No recommendations' in result[0]['Name']
</code_context>

<issue_to_address>
**suggestion (testing):** Test assumes 'No recommendations' is always present for disabled status.

If zero recommendations are reported differently in the future, this assertion could break. Consider updating the test to handle both 'No recommendations' and an empty result list for greater robustness.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +319 to +320
result = session.recommendationstab.apply_filter("Status", "Disabled")
assert 'No recommendations' in result[0]['Name']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): Test assumes 'No recommendations' is always present for disabled status.

If zero recommendations are reported differently in the future, this assertion could break. Consider updating the test to handle both 'No recommendations' and an empty result list for greater robustness.

@LadislavVasina1
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_rhcloud_iop.py -k "test_iop_recommendations_remediation_type_and_status"

@LadislavVasina1
Copy link
Contributor

Docs are not happy about the component change
image

@LadislavVasina1
Copy link
Contributor

Test looks good overall, pending PRT. Please look into the component naming @ColeHiggins2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.18.z Introduced in or relating directly to Satellite 6.18 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches RFE Issues that are requesting an enhancement to robottelo Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants