Skip to content

[6.17.z] Fix generating of hostname prefix (#20007) #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

[6.17.z] Fix generating of hostname prefix (#20007) #20023

merged 1 commit into from
Oct 21, 2025
+7 −2

Conversation

rmynar
Copy link
Contributor

@rmynar rmynar commented Oct 17, 2025

cherrypick of #20007 into 6.17.z
closes #20010

@rmynar rmynar self-assigned this Oct 17, 2025
@rmynar rmynar added No-CherryPick PR doesnt need CherryPick to previous branches Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs labels Oct 17, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Oct 17, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rmynar
Copy link
Contributor Author

rmynar commented Oct 17, 2025

trigger: test-robottelo
pytest: tests/foreman/api/test_settings.py -k 'test_positive_update_hostname_default_prefix'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 13224
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_settings.py -k test_positive_update_hostname_default_prefix --external-logging
Test Result : =========== 1 failed, 17 deselected, 5 warnings in 905.32s (0:15:05) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 17, 2025
@rmynar @lpramuk
Fix generating of hostname prefix (SatelliteQE#20007)
89c74f9 
fix generating of hostname prefix

Co-authored-by: Lukas Pramuk <[email protected]>
(cherry picked from commit 431c943)
@rmynar
Copy link
Contributor Author

rmynar commented Oct 17, 2025

trigger: test-robottelo
pytest: tests/foreman/api/test_settings.py -k 'test_positive_update_hostname_default_prefix'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 13228
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_settings.py -k test_positive_update_hostname_default_prefix --external-logging
Test Result : =========== 1 passed, 17 deselected, 5 warnings in 864.23s (0:14:24) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Oct 17, 2025
@pondrejk pondrejk merged commit 9c62aab into SatelliteQE:6.17.z Oct 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@pondrejk pondrejk pondrejk approved these changes

Assignees

@rmynar rmynar

Labels

Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmynar @Satellite-QE @pondrejk