tags for mcp images

[pondrejk]

Problem Statement

downstream registry no longer picks latest when no tag is specified

Solution

specifying tags explicitely

Related Issues

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/sys/test_mcp.py -k test_positive_call_mcp_server

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

Blocking issues:

• Detected possible formatted SQL query. Use parameterized queries instead. (link)
• Avoiding SQL string concatenation: untrusted input concatenated with raw SQL query can result in SQL Injection. In order to execute raw query safely, prepared statement should be used. SQLAlchemy provides TextualSQL to easily used prepared statement with named parameters. For complex SQL composition, use SQL Expression Language or Schema Definition Language. In most cases, SQLAlchemy ORM will be a better option. (link)

General comments:

• Avoid hardcoding the tag value ("6.18") in the function—make the version tag configurable via settings or an environment variable so it stays in sync with future image updates.
• The run_cmd uses image_name, but it isn’t explicitly tagged—ensure image_name includes the same tag you pull (or append :{tag}) to prevent pulling one version and running another.
• Re-adding a .strip() (or otherwise normalizing whitespace) on the multiline run_cmd string can help avoid unintended spaces or newlines when executing the command.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Avoid hardcoding the tag value ("6.18") in the function—make the version tag configurable via settings or an environment variable so it stays in sync with future image updates.
- The run_cmd uses `image_name`, but it isn’t explicitly tagged—ensure `image_name` includes the same tag you pull (or append `:{tag}`) to prevent pulling one version and running another.
- Re-adding a `.strip()` (or otherwise normalizing whitespace) on the multiline `run_cmd` string can help avoid unintended spaces or newlines when executing the command.

## Individual Comments

### Comment 1
<location> `pytest_fixtures/component/mcp.py:79` </location>
<code_context>
    assert target_sat.execute(pull_cmd).status == 0
</code_context>

<issue_to_address>
**security (python.lang.security.audit.formatted-sql-query):** Detected possible formatted SQL query. Use parameterized queries instead.

*Source: opengrep*
</issue_to_address>

### Comment 2
<location> `pytest_fixtures/component/mcp.py:79` </location>
<code_context>
    assert target_sat.execute(pull_cmd).status == 0
</code_context>

<issue_to_address>
**security (python.sqlalchemy.security.sqlalchemy-execute-raw-query):** Avoiding SQL string concatenation: untrusted input concatenated with raw SQL query can result in SQL Injection. In order to execute raw query safely, prepared statement should be used. SQLAlchemy provides TextualSQL to easily used prepared statement with named parameters. For complex SQL composition, use SQL Expression Language or Schema Definition Language. In most cases, SQLAlchemy ORM will be a better option.

*Source: opengrep*
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Satellite-QE]

PRT Result

Build Number: 13235
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/sys/test_mcp.py -k test_positive_call_mcp_server --external-logging
Test Result : ====== 1 failed, 1 passed, 5 deselected, 25 warnings in 774.49s (0:12:54) ======

[sourcery-ai]

New security issues found

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/sys/test_mcp.py -k test_positive_call_mcp_server

[Satellite-QE]

PRT Result

Build Number: 13246
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/sys/test_mcp.py -k test_positive_call_mcp_server --external-logging
Test Result : =========== 2 passed, 5 deselected, 38 warnings in 711.84s (0:11:51) ===========

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/sys/test_mcp.py -k test_positive_call_mcp_server

[Satellite-QE]

PRT Result

Build Number: 13247
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/sys/test_mcp.py -k test_positive_call_mcp_server --external-logging
Test Result : =========== 2 passed, 5 deselected, 39 warnings in 863.91s (0:14:23) ===========