Skip to content

Add deploy_network_type to broker nicks #20038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add deploy_network_type to broker nicks #20038

wants to merge 1 commit into from
+28 −5

Conversation

lpramuk
Copy link
Contributor

@lpramuk lpramuk commented Oct 20, 2025 •
edited
Loading

Problem Statement

Nicks are nicks so we have to tell Jake about it:

socket.gaierror: [Errno -5] No address associated with hostname

Solution

Add deploy_network_type to broker nicks so that content hosts with correct network type (ipv4 vs. ipv6) are deployed

Related Issues

SAT-37379

@lpramuk lpramuk requested review from a team as code owners October 20, 2025 19:28
sourcery-ai[bot]
sourcery-ai bot reviewed Oct 20, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lpramuk lpramuk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z 6.17.z 6.18.z Introduced in or relating directly to Satellite 6.18 labels Oct 20, 2025
@lpramuk
Copy link
Contributor Author

lpramuk commented Oct 20, 2025 

trigger: test-robottelo
network_type: ipv6
pytest: >-
  -v
  tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare
  tests/foreman/cli/test_hostcollection.py::test_positive_register_host_ak_with_host_collection
  tests/foreman/ui/test_activationkey.py::test_positive_host_associations
  tests/foreman/ui/test_hostcollection.py::test_positive_install_package
  tests/foreman/ui/test_hostcollection.py::test_positive_remove_package
  tests/foreman/ui/test_hostcollection.py::test_positive_upgrade_package
  tests/foreman/ui/test_hostcollection.py::test_positive_install_package_group
  tests/foreman/ui/test_hostcollection.py::test_positive_remove_package_group
  tests/foreman/ui/test_hostcollection.py::test_positive_install_errata
  tests/foreman/ui/test_hostcollection.py::test_positive_change_assigned_content
  tests/foreman/ui/test_hostcollection.py::test_positive_install_module_stream
  tests/foreman/ui/test_hostcollection.py::test_positive_install_modular_errata

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 13238
Build Status: UNSTABLE
PRT Comment: pytest -v tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare tests/foreman/cli/test_hostcollection.py::test_positive_register_host_ak_with_host_collection tests/foreman/ui/test_activationkey.py::test_positive_host_associations tests/foreman/ui/test_hostcollection.py::test_positive_install_package tests/foreman/ui/test_hostcollection.py::test_positive_remove_package tests/foreman/ui/test_hostcollection.py::test_positive_upgrade_package tests/foreman/ui/test_hostcollection.py::test_positive_install_package_group tests/foreman/ui/test_hostcollection.py::test_positive_remove_package_group tests/foreman/ui/test_hostcollection.py::test_positive_install_errata tests/foreman/ui/test_hostcollection.py::test_positive_change_assigned_content tests/foreman/ui/test_hostcollection.py::test_positive_install_module_stream tests/foreman/ui/test_hostcollection.py::test_positive_install_modular_errata --external-logging
Test Result : ================== 2 warnings, 12 errors in 159.53s (0:02:39) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 20, 2025
@lpramuk
Copy link
Contributor Author

lpramuk commented Oct 20, 2025 

trigger: test-robottelo
network_type: ipv6
pytest: >-
  -v
  tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare
  tests/foreman/cli/test_hostcollection.py::test_positive_register_host_ak_with_host_collection
  tests/foreman/ui/test_activationkey.py::test_positive_host_associations
  tests/foreman/ui/test_hostcollection.py::test_positive_install_package
  tests/foreman/ui/test_hostcollection.py::test_positive_remove_package
  tests/foreman/ui/test_hostcollection.py::test_positive_upgrade_package
  tests/foreman/ui/test_hostcollection.py::test_positive_install_package_group
  tests/foreman/ui/test_hostcollection.py::test_positive_remove_package_group
  tests/foreman/ui/test_hostcollection.py::test_positive_install_errata
  tests/foreman/ui/test_hostcollection.py::test_positive_change_assigned_content
  tests/foreman/ui/test_hostcollection.py::test_positive_install_module_stream
  tests/foreman/ui/test_hostcollection.py::test_positive_install_modular_errata

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 13239
Build Status: UNSTABLE
PRT Comment: pytest -v tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare tests/foreman/cli/test_hostcollection.py::test_positive_register_host_ak_with_host_collection tests/foreman/ui/test_activationkey.py::test_positive_host_associations tests/foreman/ui/test_hostcollection.py::test_positive_install_package tests/foreman/ui/test_hostcollection.py::test_positive_remove_package tests/foreman/ui/test_hostcollection.py::test_positive_upgrade_package tests/foreman/ui/test_hostcollection.py::test_positive_install_package_group tests/foreman/ui/test_hostcollection.py::test_positive_remove_package_group tests/foreman/ui/test_hostcollection.py::test_positive_install_errata tests/foreman/ui/test_hostcollection.py::test_positive_change_assigned_content tests/foreman/ui/test_hostcollection.py::test_positive_install_module_stream tests/foreman/ui/test_hostcollection.py::test_positive_install_modular_errata --external-logging
Test Result : ================== 2 warnings, 12 errors in 180.01s (0:03:00) ==================

@lpramuk
Copy link
Contributor Author

lpramuk commented Oct 21, 2025 

trigger: test-robottelo
network_type: ipv6
pytest: >-
  -v
  tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare
  tests/foreman/cli/test_hostcollection.py::test_positive_register_host_ak_with_host_collection
  tests/foreman/ui/test_activationkey.py::test_positive_host_associations
  tests/foreman/ui/test_hostcollection.py::test_positive_install_package
  tests/foreman/ui/test_hostcollection.py::test_positive_remove_package
  tests/foreman/ui/test_hostcollection.py::test_positive_upgrade_package
  tests/foreman/ui/test_hostcollection.py::test_positive_install_package_group
  tests/foreman/ui/test_hostcollection.py::test_positive_remove_package_group
  tests/foreman/ui/test_hostcollection.py::test_positive_install_errata
  tests/foreman/ui/test_hostcollection.py::test_positive_change_assigned_content
  tests/foreman/ui/test_hostcollection.py::test_positive_install_module_stream
  tests/foreman/ui/test_hostcollection.py::test_positive_install_modular_errata

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 13241
Build Status: UNSTABLE
PRT Comment: pytest -v tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare tests/foreman/cli/test_hostcollection.py::test_positive_register_host_ak_with_host_collection tests/foreman/ui/test_activationkey.py::test_positive_host_associations tests/foreman/ui/test_hostcollection.py::test_positive_install_package tests/foreman/ui/test_hostcollection.py::test_positive_remove_package tests/foreman/ui/test_hostcollection.py::test_positive_upgrade_package tests/foreman/ui/test_hostcollection.py::test_positive_install_package_group tests/foreman/ui/test_hostcollection.py::test_positive_remove_package_group tests/foreman/ui/test_hostcollection.py::test_positive_install_errata tests/foreman/ui/test_hostcollection.py::test_positive_change_assigned_content tests/foreman/ui/test_hostcollection.py::test_positive_install_module_stream tests/foreman/ui/test_hostcollection.py::test_positive_install_modular_errata --external-logging
Test Result : =========== 1 failed, 11 passed, 1686 warnings in 5228.46s (1:27:08) ===========

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@lpramuk lpramuk

Labels

6.16.z 6.17.z 6.18.z Introduced in or relating directly to Satellite 6.18 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lpramuk @Satellite-QE