Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick: #270 fix to v0.14 #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevingentile
Copy link

@kevingentile kevingentile commented Aug 11, 2021

Currently not in a position to upgrade to netcoreapp 5.0 and require this fix for v14

This branch was based off tag v0.14.1

…mework#274)

Add the additionalMime list to ResponseCompressionDefaults.MimeTypes.
(appearently the passed options do not contain the defaults)

Co-authored-by: Norman Krämer <[email protected]>
(cherry picked from commit 8e27614)
@kevingentile kevingentile changed the title Cherry-Pick: #270 fix to v14 Cherry-Pick: #270 fix to v0.14 Aug 11, 2021
@tforkmann
Copy link
Contributor

#270 got already closed in 2020.
Is this issue still open?

@cartermp
Copy link
Collaborator

I'm inclined not to do this. @kevingentile how are you planning to consume this fix in v0.14, build from source? There's no way to back-port it to that release in NuGet.

@kevingentile
Copy link
Author

kevingentile commented Jan 15, 2022

@cartermp Thank you for your time. A v0.14.2 would be sufficient.

The framework change from netcoreapp3.1 in v0.14 to net5.0 in v0.15 was a breaking change. Consumers with similar limitations will always own this bug.

Workaround is to implement and use a local copy of UseGZip with 8e27614 to re-enable JSON compression.

EDIT: Looking at the build workflow at v0.14.1, you would need a protected v0.14.x branch at v0.14.1 to base this PR. Then a tag and push v0.14.2 after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants