Skip to content

feat: Compress other wallets into a modal on DEVNET #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

emarc99
Copy link

@emarc99 emarc99 commented Jul 2, 2025

In DEVNET only: Hide Argent, Braavos, and other 3rd-party wallet buttons from the main wallet connect modal.

Types of change

  • Feature
  • Bug
  • Enhancement

Summary of Steps

  1. Detect if the app is running on DEVNET.
  2. In the wallet connect modal,
    • If on DEVNET, show only default wallet(s) + “Other Options” button.
    • On “Other Options” click, show a modal with Argent, Braavos, etc.
  3. If not on DEVNET, show all wallets as usual.

@emarc99
Copy link
Author

emarc99 commented Jul 2, 2025

Screenshot 2025-07-02 035612
Screenshot 2025-07-02 084833

@emarc99 emarc99 changed the base branch from main to develop July 2, 2025 08:10
@metalboyrick metalboyrick changed the title Feat: Compress other wallets into a modal on DEVNET feat: Compress other wallets into a modal on DEVNET Jul 3, 2025
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GM Ser, thanks for the PR

Please keep styling consistent with other buttons (you can just use the style from there) (or you can just use ghost buttons for this)

image

@emarc99
Copy link
Author

emarc99 commented Jul 3, 2025

Can you, please, be more specific?

Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a ghost button as well?

image

Also please make sure the CI is green

@emarc99
Copy link
Author

emarc99 commented Jul 4, 2025

@metalboyrick done ser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compress Argent, Bravoos and other 3rd-Party Wallets to “Other Options” button in Devnet
2 participants