Fix 575 #590
Closed
Fix 575 #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalboyrick
requested changes
Jul 3, 2025
There was a problem hiding this comment.
GM Thanks for the PR! Comments down below
On the PR:
- Please rebase your branch to the latest develop
- please put the appropriate title (e.g.
feat: implement...) - Please re-read the issue and try to understand the intention behind the task, feel free to consult us if you have any questions
There was a problem hiding this comment.
I don't think you need to implement a contract
There was a problem hiding this comment.
I don't think you need to implement a contract
Comment on lines
+99
to
+108
| const multicallResult = useReadContract({ | ||
| functionName: "call_contracts", | ||
| address: multicallContract?.address, | ||
| abi: multicallContract?.abi, | ||
| watch: true, | ||
| args: [contracts, entryPointSelectors, calldata], | ||
| enabled: allContractsReady && contracts.length > 0, | ||
| blockIdentifier: "pending" as BlockNumber, | ||
| ...readConfig, | ||
| }); |
There was a problem hiding this comment.
We are not supposed to call a particular contract here, you have to use starknet.js or starknet-react to implement a hook that can read multiple contracts at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement use Scaffold multiread hook
Fixes #575
Types of change
Comments (optional)