-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pheobeayo, really appreciate your PR!
However I think you've misunderstood the issue, what i meant is explaining to users that we have a faucet feature that they can use in devnet to fill in their wallet in case they need any gas funds, and the sepolia faucet info that will lead them into the external starknet sepolia faucets.
You can access the faucet on the bottom of the scaffold stark app.
Thank you!
okay , will make the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments! Don't worry you still have some time to make the changes! All the best!
docs/deploying/deploy-faucets.mdx
Outdated
|
||
These three options are available for any user to get Starknet Sepolia Faucets | ||
|
||
### [Starknet Foundation](https://starknet-faucet.vercel.app/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be bullet points, no headers here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pheobeayo not resolved yet
docs/deploying/deploy-faucets.mdx
Outdated
toc_max_heading_level: 5 | ||
--- | ||
|
||
# Faucets (Available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just say "Faucets"
docs/deploying/deploy-faucets.mdx
Outdated
|
||
Faucets for deployment of smart contracts can be requested from the website. | ||
|
||
The button is at the bottom left of the [Demo app] (https://scaffold-stark-demo.vercel.app/debug) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pheobeayo This is not resolved yet, you can try editing while running the localhost instance with yarn start
. The vscode markdown doesn't necessarily give you the right representation.
docs/deploying/deploy-faucets.mdx
Outdated
 | ||
|
||
|
||
## Websites available for Starknet Sepolia faucets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need some docs on the Devnet faucet, which looks different from this sepolia window. The devnet one allows user to fill in their own wallet with some tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this section, we can just say "Starknet Sepolia Faucets"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pheobeayo I meant the title could just be "Starknet Sepolia Faucets" instead of "Websites available ...."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and can remove the sub "Starknet Sepolia Faucets"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for the devnet, please indicate the UI path also. as shown by @Nadai2010
docs/deploying/deploy-faucets.mdx
Outdated
 | ||
|
||
|
||
## Websites available for Starknet Sepolia faucets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this section, we can just say "Starknet Sepolia Faucets"
Hi @pheobeayo great jobs, thank you, some details
curl -d '{"amount":1000000000000000000, "address":"0x064b48806902a367c8598f4f95c305e8c1a1acba5f082d294a43793113115691"}' -H "Content-Type: application/json" -X POST http://localhost:5050/mint |
Hey @pheobeayo, some of the changes are still not addressed, feel free to ping us should you have any questions! |
@Nadai2010, the picture was added for the Devnet local faucets. Where can I get that, please? @metalboyrick The link in the Demo app which isn't not giving the right link is actually giving the right link with me wherever I click on it, Please what could be wrong? |
Hi @pheobeayo, I think you can use image hat I shared , if you want to access the faucet on devnet, you should follow the Scaffold Stark repository and follow the steps to lift the UI |
@pheobeayo the devnet can only be accessed if you make a local copy of the repo. you cannot use the demo link for that |
Yes, I understand, I did my research too, Kindly review the changes I made on the PR @metalboyrick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the hard work!
Thank you for the support all along, it was great contributing to this! @metalboyrick @Nadai2010 |
Add documentation for Local and Sepolia Faucets
Fixes #24
Types of change
Comments (optional)