Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add documentation for useScaffoldStrkBalance and useScaffoldEth… #28

Merged
merged 3 commits into from
Oct 6, 2024
Merged

feat: add documentation for useScaffoldStrkBalance and useScaffoldEth… #28

merged 3 commits into from
Oct 6, 2024
+146 −0

Conversation

Calebux
Copy link
Contributor

@Calebux Calebux commented Oct 5, 2024

Task name here

feat: add documentation for useScaffoldStrkBalance and useScaffoldEth…

Types of change

  • Enhancement

metalboyrick
metalboyrick requested changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, overall nicely done! I like how you put out the best practice guide. Just some minor comments for adjustments

@Calebux
Copy link
Contributor Author

Calebux commented Oct 5, 2024

Changes effected

@metalboyrick
Copy link
Collaborator

Fixes #26

@metalboyrick metalboyrick linked an issue Oct 5, 2024 that may be closed by this pull request
Document useScaffoldEthBalance and useScaffoldStrkBalance #26
Closed
@Calebux
Copy link
Contributor Author

Calebux commented Oct 5, 2024

Please check now

@metalboyrick metalboyrick self-requested a review October 6, 2024 11:33
metalboyrick
metalboyrick approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@metalboyrick metalboyrick merged commit 751651d into Scaffold-Stark:main Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalboyrick metalboyrick metalboyrick approved these changes

@Nadai2010 Nadai2010 Nadai2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document useScaffoldEthBalance and useScaffoldStrkBalance
3 participants
@Calebux @metalboyrick @Nadai2010