Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update Balance component documentation #29

Merged
merged 7 commits into from
Oct 7, 2024
Merged

docs: update Balance component documentation #29

merged 7 commits into from
Oct 7, 2024

Conversation

0xdevcollins
Copy link
Contributor

@0xdevcollins 0xdevcollins commented Oct 6, 2024 •
edited
Loading

Balance component update GIF and description update #20

Fixes #relevant-issue-here

Types of change

  • Enhancement

Comments (optional)

This PR updates the documentation for the Balance component, reflecting recent enhancements to the balance display functionality, including:

Added support for toggling between ETH/STRK and USD balances.
Improved loading state handling and error messages.
New screenshot added to illustrate the updated component behavior.

@metalboyrick metalboyrick self-requested a review October 7, 2024 02:46
@metalboyrick metalboyrick linked an issue Oct 7, 2024 that may be closed by this pull request
Balance component update GIF and description update #20
Closed
metalboyrick
metalboyrick requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work ! I like the concise approach ! Just a small change and you're good!

docs/components/Balance.md Outdated Show resolved Hide resolved
@0xdevcollins
Copy link
Contributor Author

@metalboyrick , Please, kindly review
image

metalboyrick
metalboyrick requested changes Oct 7, 2024
View reviewed changes
docs/components/Balance.md Outdated Show resolved Hide resolved
@0xdevcollins
Copy link
Contributor Author

image

metalboyrick
metalboyrick approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the hard work!

@metalboyrick metalboyrick merged commit af8d47f into Scaffold-Stark:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalboyrick metalboyrick metalboyrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Balance component update GIF and description update
2 participants
@0xdevcollins @metalboyrick