-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: configure contracts page #33
Conversation
Hi @mexes20, good work, but in this documentation I think a simple guide with images with the steps to follow would be very useful. We also have to clarify that it will depend on the chain added in scaffold.config.ts, it will access to download a contract in the |
Hi @mexes20, please note that ODHack8 is ending soon! I think you should be good once you resolve @Nadai2010 comments! |
Alright, I'm on it now. |
@metalboyrick @Nadai2010 Kindly review, I made a couple of Improvements to the doc for more clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies I know I said that we're good but I realized theres some changes needed to be done
@metalboyrick Kindly review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi sir, seems you have not addressed Nadai's changes properly.
I added an explaination of it in the doc with a sample example just as @Nadai2010 requested. But with the PR I sent now, I've added the scaffold.config.ts for more clarity. |
@metalboyrick Kindly review, I'm here to make any further changes that may be required, thanks. |
}; | ||
|
||
const scaffoldConfig = { | ||
targetNetworks: [chains.devnet], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just include this part ser, no need to include the entire file, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay ser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ser, kindly review @metalboyrick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Task name here
Fixes Issue 21
Types of change