Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add Algolia search configuration to docusaurus.config.js #66

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

mimisavage
Copy link
Contributor

Task name here

Fixes #61

Types of change

  • Bug
  • Enhancement

Comments (optional)

@mimisavage
Copy link
Contributor Author

image

@mimisavage
Copy link
Contributor Author

image

Copy link
Collaborator

@Nadai2010 Nadai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good jobs for me, thanks @mimisavage, @metalboyrick can check?

@mimisavage
Copy link
Contributor Author

@metalboyrick pelase what is your telegram username so i can share the env details ?

@metalboyrick
Copy link
Collaborator

@mimisavage it's the same name as the github.

you should be able to do it here (you can give it any name you like, e.g. ALGOLIA_API_KEY). Then use process.env.ALGOLIA_API_KEY to access within the app, at the same time creating a new file .env.example to put this variable as example

@mimisavage
Copy link
Contributor Author

@mimisavage it's the same name as the github.

you should be able to do it here (you can give it any name you like, e.g. ALGOLIA_API_KEY). Then use process.env.ALGOLIA_API_KEY to access within the app, at the same time creating a new file .env.example to put this variable as example

I did this in my recent commit here f77fe00

@metalboyrick
Copy link
Collaborator

@mimisavage please wait, I will soon make corresponding changes to the CI so that it will unblock this PR

@metalboyrick
Copy link
Collaborator

No more comments on my end!

@metalboyrick metalboyrick mentioned this pull request Dec 19, 2024
2 tasks
@metalboyrick metalboyrick self-requested a review December 20, 2024 03:16
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, CI PR will be merged after ODHack ends. Seems like we might experience some hiccups while it is not merged yet since server is not set yet. cc @Nadai2010 @0xquantum3labs

@metalboyrick
Copy link
Collaborator

Thanks for the PR @mimisavage !

@metalboyrick
Copy link
Collaborator

considering that this PR may break the CI, will be holding it back until other OD PRs are merged.

@mimisavage
Copy link
Contributor Author

s PR may break the CI, will be holding it back until other OD PRs are merged.

Okay sir. Thank you

@metalboyrick metalboyrick merged commit b8b9175 into Scaffold-Stark:main Dec 24, 2024
1 check failed
@metalboyrick
Copy link
Collaborator

gm @mimisavage do you have tg that we can connect with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add a search engine, magnifying glass or similar
3 participants