Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Productionizing Guide #56 #68

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

martinvibes
Copy link
Contributor

Task name here

[DOCS] Productionizing Guide #56

Fixes #56

Types of change

  • [] Bug
  • Enhancement

Comments (optional)

@martinvibes
Copy link
Contributor Author

hey @metalboyrick kindly review :)

Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments, will chime in @iossocket for review too, thanks for the PR!

docs/deploying/deploy-production.mdx Outdated Show resolved Hide resolved
docs/deploying/deploy-production.mdx Outdated Show resolved Hide resolved
docs/deploying/deploy-production.mdx Show resolved Hide resolved
@martinvibes
Copy link
Contributor Author

hey @metalboyrick implemented requested changes :)

Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but let's chime in @iossocket for review.

@metalboyrick metalboyrick merged commit 7e718b7 into Scaffold-Stark:main Dec 22, 2024
1 check passed
@metalboyrick
Copy link
Collaborator

will be iterated within the team cc @Nadai2010 @iossocket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Productionizing Guide
3 participants