Skip to content

Conversation

@justinc1
Copy link
Collaborator

@justinc1 justinc1 commented Sep 8, 2025

PR introduces a few small changes for easier local testing.

A pylint was complaining.

A ci-infra/helpers/run-tests.sh makes it easier to run and retry only failed integration tests.
It is intended for testing locally, on developers laptop. usage:

  • On first run, all tests (or only those listed in test-names.txt) are run.
  • Test result in stored in test-names.txt.
  • On second run, only tests marked as failed in test-names.txt are retried.

A docker compose to setup SMB server for VM import/export testing is added. With this, I was able to check vm_import and vm_export modules do work.

A shutdown timeout for vm_snapshot_attach_disk is adjusted, to make test faster.

@justinc1 justinc1 requested a review from anazobec September 8, 2025 18:44
@justinc1 justinc1 self-assigned this Sep 8, 2025
@justinc1 justinc1 force-pushed the hc-v955 branch 2 times, most recently from 75250af to 7a3c5d8 Compare September 8, 2025 20:02
@justinc1 justinc1 force-pushed the hc-v955 branch 2 times, most recently from 5fbd525 to 5d2c019 Compare September 30, 2025 06:43
Copy link
Collaborator

@anazobec anazobec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, @justinc1! LGTM

@justinc1 justinc1 merged commit c27c1d3 into main Oct 14, 2025
29 checks passed
@justinc1 justinc1 deleted the hc-v955 branch October 14, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants