Skip to content

Conversation

@justinc1
Copy link
Collaborator

@justinc1 justinc1 commented Sep 8, 2025

Logout from HyperCore when module finishes. Otherwise HyperCore needs to auto-close oldest connections (the least recently used one), and this sometimes selects "wrong" connection. For example, while running integration tests, the browser session might get logged out.

@justinc1 justinc1 requested a review from anazobec September 8, 2025 19:10
@justinc1 justinc1 force-pushed the logout branch 4 times, most recently from f98774e to 45937c7 Compare September 8, 2025 20:00
@justinc1 justinc1 self-assigned this Sep 8, 2025
@justinc1 justinc1 force-pushed the logout branch 4 times, most recently from ed04f92 to 3d6a675 Compare September 30, 2025 06:48
Copy link
Collaborator

@anazobec anazobec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Implementation looks good, thanks @justinc1!

Signed-off-by: Justin Cinkelj <[email protected]>
@justinc1 justinc1 merged commit fde5fe4 into main Oct 14, 2025
29 checks passed
@justinc1 justinc1 deleted the logout branch October 14, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants