Skip to content

Conversation

@justinc1
Copy link
Collaborator

PR wants to use same linters as https://github.com/ansible-collections/amazon.aws uses.
This should make it easy to test with correct ansible-lint version etc.

Some mechanical code changes were needed.

Copy link
Collaborator

@anazobec anazobec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good from my side. Thanks @justinc1!

@justinc1 justinc1 force-pushed the ci-gha branch 2 times, most recently from 3fb01a4 to 4b577c7 Compare September 29, 2025 06:47
Signed-off-by: Justin Cinkelj <[email protected]>
Signed-off-by: Justin Cinkelj <[email protected]>
Avoid using next, input, open, type as function parameter name
Refactor a few for loop to use .items()

Signed-off-by: Justin Cinkelj <[email protected]>
Signed-off-by: Justin Cinkelj <[email protected]>
Signed-off-by: Justin Cinkelj <[email protected]>
@justinc1 justinc1 merged commit 4e5a896 into main Sep 30, 2025
6 checks passed
@justinc1 justinc1 deleted the ci-gha branch September 30, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants