Skip to content

[Resolve #1482] Make shell optional in cmd hook #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iainelder
Copy link
Contributor

Now you can set the command to run as an object without also having to set the shell.

In this case it uses the default shell, as if the command to run were passed as a string.

This allows you to use resolvers to set the command without worrying about which shell to invoke. See @dmarra's use case in #1482.

[Your PR description here]

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

Now you can set the command to run as an object without also having to set the
shell.

In this case it uses the default shell, as if the command to run were passed as a
string.

This allows you to use resolvers to set the command without worrying about which
shell to invoke. See @dmarra's use case in Sceptre#1482.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant