[Draft] Adding concurrency options to launch command #1560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've encountered issues while using the launch command to do with the number of requests it's making. Upon inspection of the code, we've figured out that there is no limit on the stack concurrency. As in scepter will run concurrent threads to create the stacks as much as the number of stacks are available in a batch.
Stack concurrency is determined by dependency. In case of stacks that have little to no dependencies, with large number of stacks, that could mean unlimited number of threads running concurrently, which had the adverse affect of bringing down our localstack server used for testing.
We've created a patch to be able to add an option to hard limit concurrency on the launch command. We hope this could be carried over to all relevant commands. We're still new users of sceptre, so we're unfamiliar with what other changes need to be done.
Pending :