-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪲 Allow glitch to distort the left side of the window #289
base: main
Are you sure you want to change the base?
Conversation
glitch_fix.mp4original_glitch.mp4 |
Hey, thanks again! However, I am a bit hesitant as to whether I want to merge this. The clamping was done on purpose. It does not only affect the left border, but the whole window: Due to the clamping, the primary waves will only distort the window if the noise value is positive, if it's negative, nothing will happen. The idea of this is, that there are periods in which the window is not distorted at all. Then, suddenly there is abrupt distortion to the right. You can see this quite nicely in original shader onto which I have built these effects: https://www.shadertoy.com/view/XtK3W3. Here, the primary waves are clamped to the left with the One could try to think of a variant which occasionally distorts the window either to the left or to the right. Like scaling the noise into the rage [-2...2]. If it's then in [-1...1] it should be set to zero (no distortion) if its in [-2...-1] it is increased by one into [-1...0] (distortion to the left) and else its reduced by one into [0...1] for distorting to the right. What do you think? |
Whoops, I see what you mean - thank you for explaining. The variant idea sounds like a good way to preserve the intended behavior. I'll give it a try |
Coursework picked back up. I think I have an idea of how to make it work, but not done yet |
That should do the trick |
Hi there! Thanks for getting back to this! I just used this for a couple of hours and I am a bit hesitant. I still have the feeling that the effect is more "wavy" and less "glitchy" in this current form. Maybe we can increase the "dead-zone" of the noise where no effect is applied? But maybe it actually is the asymmetry which emphasizes the glitchy appearance... |
Glitch (and TV-Glitch) clamps the noise to a positive value, and squares it later, making noise positive only. As a result, the left border can be distorted right, but never left. This commit changes the clamping from 0,1 to -1,1, and adds a
sign
call to the squaring operation.TODO: obs before/after recordings when I get homesee next comment