Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
larsrickert committed Jan 24, 2025
1 parent b1663e3 commit 5be9129
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,14 @@ for (const modifier of ["Alt", "ControlOrMeta", "Shift"] as const) {
test(`should not open internal link if clicked with modifier "${modifier}""`, async ({
page,
mount,
browserName,
}) => {
// eslint-disable-next-line playwright/no-conditional-in-test -- Alt does not work in safari
if (browserName === "webkit" && modifier === "Alt") {

Check warning

Code scanning / ESLint

Disallow conditional logic in tests Warning

Avoid having conditionals in tests
// eslint-disable-next-line playwright/no-skipped-test -- Alt does not work in safari
return test.skip();

Check warning

Code scanning / ESLint

Prevent usage of the `.skip()` skip test annotation. Warning

Unexpected use of the .skip() annotation.
}

Check warning

Code scanning / ESLint

Disallow conditional logic in tests Warning

Avoid having conditionals in tests

// ARRANGE
const component = await mount(<TestWrapper href="/test-page">Test link</TestWrapper>);

Expand Down

0 comments on commit 5be9129

Please sign in to comment.