WIP: Unify System creation during conversion #1357
Open
+868
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
changed the title
Systems created by make_cle_sde with constraint equations use the Brownian-based path which requires mtkcompile before creating an SDEProblem. This fixes the test failure in ReactionSystem Structure tests. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests expecting ODE metadata to be preserved should use make_hybrid_model instead of make_sck_jump, since make_sck_jump explicitly ignores ODE/SDE metadata (only preserving VariableRateJump metadata). Co-Authored-By: Claude Opus 4.5 <[email protected]>
The upstream ModelingToolkit.jl issue #4030 has been resolved in ModelingToolkitBase v1.8.0. The discrete parameter event tests for SDE and Jump simulations now pass, so @test_broken is changed to @test. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TorkelE this is a start on the system conversion updates. I kept pure SDE models with no constraints using noise_eqs, but added a kwarg that allows switching to using Brownians. Hybrid models or models with constraints use Brownians. There is also an explicit
HybridProblemfunction if one wants to directly generate theJumpProblemassociated with a hybrid model --JumpProblemforces everything to be jumps for consistency with ODE and SDE problems (I need to update that for hybrid models without jumps). I also didn't update the nonlinear system code to use the hybrid system function, since that is a different model type.This should be pretty backwards compatible in that I don't think any non-hybrid model tests need updating.