Skip to content

Commit

Permalink
Disable just the faulty branch of the early return optimization, sinc…
Browse files Browse the repository at this point in the history
…e DDEs rely on the other branch
  • Loading branch information
hersle committed Jul 20, 2024
1 parent 93d13fb commit 19e8a89
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,7 @@ function promote_to_concrete(vs; tofloat = true, use_union = true)
T = eltype(vs)

# return early if there is nothing to do
# TODO: reenable after it was disabled to fix missing errors in https://github.com/SciML/ModelingToolkit.jl/issues/2873
#Base.isconcretetype(T) && (!tofloat || T === float(T)) && return vs
Base.isconcretetype(T) && (!tofloat#= || T === float(T)=#) && return vs # TODO: disabled float(T) to restore missing errors in https://github.com/SciML/ModelingToolkit.jl/issues/2873

sym_vs = filter(x -> SymbolicUtils.issym(x) || SymbolicUtils.iscall(x), vs)
isempty(sym_vs) || throw_missingvars_in_sys(sym_vs)
Expand Down

0 comments on commit 19e8a89

Please sign in to comment.