refactor: make repack call replace

SciML · Aug 19, 2024 · c457d32 · c457d32
1 parent 1fd513e
commit c457d32
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/src/systems/parameter_buffer.jl b/src/systems/parameter_buffer.jl
@@ -264,10 +264,7 @@ function SciMLStructures.canonicalize(::SciMLStructures.Tunable, p::MTKParameter
     arr = p.tunable
     repack = let p = p
         function (new_val)
-            if new_val !== p.tunable
-                copyto!(p.tunable, new_val)
-            end
-            return p
+            return SciMLStructures.replace(SciMLStructures.Tunable(), p, new_val)
         end
     end
     return arr, repack, true
@@ -288,12 +285,9 @@ for (Portion, field, recurse) in [(SciMLStructures.Discrete, :discrete, 2)
                                   (Nonnumeric, :nonnumeric, 1)]
     @eval function SciMLStructures.canonicalize(::$Portion, p::MTKParameters)
         as_vector = buffer_to_arraypartition(p.$field)
-        repack = let as_vector = as_vector, p = p
+        repack = let p = p
             function (new_val)
-                if new_val !== as_vector
-                    update_tuple_of_buffers(new_val, p.$field)
-                end
-                p
+                return SciMLStructures.replace(($Portion)(), p, new_val)
             end
         end
         return as_vector, repack, true