Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename states to unknowns, and related changes #2432

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Jan 25, 2024

  • also some bug fixes

Requires the following for tests to pass:

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review January 29, 2024 07:41
@AayushSabharwal
Copy link
Member Author

Tests pass locally with the above mentioned PRs

@AayushSabharwal AayushSabharwal mentioned this pull request Jan 29, 2024
11 tasks
@ChrisRackauckas ChrisRackauckas merged commit 74cada4 into SciML:master Jan 30, 2024
17 of 22 checks passed
@AayushSabharwal AayushSabharwal deleted the as/states-unknowns branch February 29, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants