Support more of the SciMLBase events API #2911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This extends
SymbolicContinuousCallback
to support theaffect_neg
androotfind
mechanisms provided by the underlying SciMLBase callback API. In particular, the semantics ofaffect_neg
are mirrored into the symbolic domain (same as affect by default; disabled ifnothing
, and usable as either the equation orFunctionalAffect
interface). The implementation ofrootfind
is somewhat more cursed; we cannot generate a singleVectorContinuousCallback
for differentrootfind
options, so instead generate several using therootfind
value as an equivalence class and then sort the resulting callbacks in order ofrootfind
. The alternative approach would be to generate aCallbackSet
if the order violated the order ofVectorContinousCallbacks
(e.g. if we had a left then right then left rootfind selection), but this comes with a performance penalty. As a result, we have a choice between impacting performance and odd semantics; I'd appreciate feedback on what the right choice is here.