Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend all arguments of a base sys to sys #3124

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ven-k
Copy link
Member

@ven-k ven-k commented Oct 15, 2024

Closes #3601

Adds the arguments of a base system to the main system.

@extends PartialSystem()

Note that we have an alternate (and the initial) syntax to avoid enforcing that PartialSystem should be defined at the time of defining higher model: @extend var_to_unpack1, var_to_unpack2 = partial_sys = PartialSystem(var1 = value1). In this syntax, the list of kwargs of PartialSystem won't be available. So, that syntax remains unchanged. One has to list all the args that should be added to the main system.
I've documented this and noted that former syntax is preferred over this.

cc @baggepinnen

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@ven-k ven-k marked this pull request as draft October 15, 2024 18:44
@ven-k ven-k marked this pull request as ready for review October 17, 2024 19:18
@ChrisRackauckas ChrisRackauckas merged commit 74412cd into SciML:master Oct 21, 2024
32 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants