feat: extend all arguments of a base sys to sys #3124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3601
Adds the arguments of a base system to the main system.
@extends PartialSystem()
Note that we have an alternate (and the initial) syntax to avoid enforcing that PartialSystem should be defined at the time of defining higher model:
@extend var_to_unpack1, var_to_unpack2 = partial_sys = PartialSystem(var1 = value1)
. In this syntax, the list of kwargs of PartialSystem won't be available. So, that syntax remains unchanged. One has to list all the args that should be added to the main system.I've documented this and noted that former syntax is preferred over this.
cc @baggepinnen
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.