fix: fix complete not properly expanding systems
#3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (eqs = equations(sys)) isa Vector && | ||
| any(eq -> eq isa Equation && isconnection(eq.lhs), eqs) | ||
| eqs = equations(sys) | ||
| if eqs isa AbstractArray && eltype(eqs) <: Equation |
There was a problem hiding this comment.
What's a case where it's not a vector?
There was a problem hiding this comment.
OptimizationSystem. equations(sys) returns the objective.
There was a problem hiding this comment.
but is there any case that is an abstractarray that's not a vector?
There was a problem hiding this comment.
JumpSystem stores it in an ArrayPartition, which is an AbstractVector but we don't want to expand_connections on that, and it would fail eltype <: Equation anyway.
ChrisRackauckas
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.