Buckingham PI implementation with DynamicQuantities#3443
Buckingham PI implementation with DynamicQuantities#3443karthik11135 wants to merge 5 commits intoSciML:masterfrom
Conversation
|
I assume this is meant to be a part of a larger PR that includes a system transformation? |
I'm a bit confused. I thought my second PR was supposed to focus solely on Buckingham PI. Could you clarify and guide me on this? |
https://en.wikipedia.org/wiki/Buckingham_%CF%80_theorem The useful thing her is the " can be rewritten", ie. a transformation of an ODESystem into a new ODESystem that is dimensionless. The buckingham pi is the first step, then the equations being generated to be dimensionless is the second. |
|
Sorry for the late response. I was caught up with a bit of college work. I have gone throught the wiki page. I understood that the obtained PI terms are to be substituted in the original equations and that I must ensure there are no dependent variables in the obtained equations. I will work on this. |
This PR contains the implementation of the BuckinghumPI. Necessary tests are also added.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.