Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion based on discussion in #3555 to "prevent" stuff like
map(eq -> eq.lhs, observed(sys))
for a little nicer API.My idea was to introduce a convenient
observeds
getter named symmetrically tounknowns
.But working through it, I realize that this leads to an "asymmetry" in the naming of
equations
andobserved(s)
.If you think this is a helpful addition, what is the best name?
observeds(sys)
?observed_variables(sys)
?unknowns(sys; observed = true)
?Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.