Add units and missing descriptions to components#214
Draft
ven-k wants to merge 17 commits intoSciML:mainfrom
Draft
Add units and missing descriptions to components#214ven-k wants to merge 17 commits intoSciML:mainfrom
ven-k wants to merge 17 commits intoSciML:mainfrom
Conversation
Member
Author
|
Merging this would throw invalidation errors for models that use this component along with unitless parameters. So this will be merged with the breaking release. |
5 tasks
- `RealInput` and `RealOutput` now accept `unit`. - All function generators now have `ouptput__unit` to set the unit of output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207