Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ODEProblem
code path since it was not neededand it made algorithm support for
run_simulation
unnecesarly complicated (see #26).Also, the
ODEProblem
code did not support thermostats from what I can tell.Since the
ODEProblem
dispatch was used for the default algorithm choice with Tsit5as the default, this changes to
VelocityVerlet
with a timestep equal to tspan/10000.I opted for
VelocityVerlet
since it is a very popular algorithm for N-body problems.The disadvantage compared with the previous default is that it increases runtimes
with about ~2 orders of magnitude, but the energy and other invariants of the
system should be conserved better. Maybe after the benchmarks we can choose a
better default.
I also adapted the indexing in some tests to match with the new solution type
and added some comments explaining the tests (what we test from the physics point of view).