Improve interface compliance for generic numeric types #1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
eltype(cord)forzeros()andMatrixconstruction inget_numeric_integral()to support BigFloat and other numeric typeseltypeθparameter inget_points_loss_functions()forzeros()andones()to maintain type consistencyTinzeros()call for consistency with the rest of the functionInterface Compliance Testing
Tested with JLArrays (GPU-like arrays) and ArrayInterface.jl to verify:
safe_get_devicecorrectly identifies device for JLArraysEltypeAdaptorworks with different array typesfast_scalar_indexingis respected (JLArrays return false)Tested with BigFloat to verify:
Test plan
cc @ChrisRackauckas
🤖 Generated with Claude Code