-
-
Notifications
You must be signed in to change notification settings - Fork 233
build(deps): bump the all-julia-packages group across 2 directories with 3 updates #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Dependency Update Compatibility FixI've analyzed this dependency update PR and identified a breaking change that needs to be addressed. IssueThe update to Symbolics v7.4.1 removed the SolutionAdd a local In
# Change from:
using Symbolics: Symbolics, unwrap, arguments, operation, build_expr, Num,
expand_derivatives
# To:
using Symbolics: Symbolics, unwrap, arguments, operation, Num,
expand_derivatives
# Helper function to replace removed Symbolics.build_expr
# build_expr was removed in Symbolics v7, this provides the same functionality
build_expr(head::Symbol, args) = Expr(head, args...)TestingI've tested this fix locally:
This is a minimal, non-breaking fix that maintains compatibility with both the new Symbolics v7 API and all existing NeuralPDE.jl code. 🤖 Generated with Claude Code |
d9f6813 to
f6c4ab0
Compare
CI Failure AnalysisThe CI is failing because the test dependencies force a downgrade of the updated packages. Root CauseMethodOfLines (a test dependency) only supports ModelingToolkit 10.x: # MethodOfLines 0.11.9 compat
ModelingToolkit = "10.1.0-10"When
What WorksNeuralPDE loads and works correctly with the new versions when tested directly (without MethodOfLines): using NeuralPDE
using ModelingToolkit # v11.5.1 ✓
using Symbolics # v7.5.0 ✓
using SymbolicUtils # v4.10.1 ✓Fixes Applied
Blocking IssueCreated #1008 to track the MethodOfLines incompatibility. Next StepsThis PR is blocked until one of these happens:
🤖 Generated with Claude Code |
Analysis of CI FailuresI've analyzed the CI failures for this dependency update. There are several issues that need to be addressed: Issues Found
Required Code FixesThe fixes are documented in issue #1009 and include:
Blocking DependencyThis PR cannot be fully tested until MethodOfLines.jl is updated to support:
See issue #1009 for the complete analysis and suggested next steps. 🤖 Generated with Claude Code |
CI Failure AnalysisThe CI is failing due to a dependency conflict with MethodOfLines. IssueMethodOfLines (a test dependency) does not yet support Symbolics 7.x. The package resolver cannot find a version of MethodOfLines that is compatible with both Upstream Dependency Status
Next StepsI've opened #1010 with detailed options for how to proceed. The main options are:
🤖 Generated with Claude Code |
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
f6c4ab0 to
252c13f
Compare
…ith 3 updates Updates the requirements on [Symbolics](https://github.com/JuliaSymbolics/Symbolics.jl), [SymbolicUtils](https://github.com/JuliaSymbolics/SymbolicUtils.jl) and [ModelingToolkit](https://github.com/SciML/ModelingToolkit.jl) to permit the latest version. Updates `Symbolics` to 7.4.1 - [Release notes](https://github.com/JuliaSymbolics/Symbolics.jl/releases) - [Changelog](https://github.com/JuliaSymbolics/Symbolics.jl/blob/master/NEWS.md) - [Commits](JuliaSymbolics/Symbolics.jl@v6.14.0...v7.4.1) Updates `SymbolicUtils` to 4.10.0 - [Release notes](https://github.com/JuliaSymbolics/SymbolicUtils.jl/releases) - [Commits](JuliaSymbolics/SymbolicUtils.jl@v3.7.2...v4.10.0) Updates `ModelingToolkit` to 11.4.0 - [Release notes](https://github.com/SciML/ModelingToolkit.jl/releases) - [Changelog](https://github.com/SciML/ModelingToolkit.jl/blob/master/NEWS.md) - [Commits](https://github.com/SciML/ModelingToolkit.jl/commits/v11.4.0) Updates `ModelingToolkit` to 11.4.0 - [Release notes](https://github.com/SciML/ModelingToolkit.jl/releases) - [Changelog](https://github.com/SciML/ModelingToolkit.jl/blob/master/NEWS.md) - [Commits](https://github.com/SciML/ModelingToolkit.jl/commits/v11.4.0) --- updated-dependencies: - dependency-name: Symbolics dependency-version: 7.4.1 dependency-type: direct:production dependency-group: all-julia-packages - dependency-name: SymbolicUtils dependency-version: 4.10.0 dependency-type: direct:production dependency-group: all-julia-packages - dependency-name: ModelingToolkit dependency-version: 11.4.0 dependency-type: direct:production dependency-group: all-julia-packages - dependency-name: ModelingToolkit dependency-version: 11.4.0 dependency-type: direct:production dependency-group: all-julia-packages ... Signed-off-by: dependabot[bot] <[email protected]>
252c13f to
cd8166b
Compare
Updates the requirements on Symbolics, SymbolicUtils and ModelingToolkit to permit the latest version.
Updates
Symbolicsto 7.4.1Release notes
Sourced from Symbolics's releases.
Changelog
Sourced from Symbolics's changelog.
Commits
e522a42Merge pull request #1733 from JuliaSymbolics/as/bump-versionae11decbuild: bump patch version201d2d2Merge pull request #1732 from JuliaSymbolics/as/fix-isaffine-ifelseb7d3f61fix: fixisaffinefor nestedifelsechains0667830Merge pull request #1731 from JuliaSymbolics/as/bump-version89a48e9build: bump minor version5a272fdMerge pull request #1707 from JuliaSymbolics/as/symstructe819773Merge pull request #1730 from JuliaSymbolics/as/fix-scala421827fix: fix some issues with scalarization ofArr78a1e08docs: add docs for new@symstructUpdates
SymbolicUtilsto 4.10.0Release notes
Sourced from SymbolicUtils's releases.
Commits
80f47d4build: bump minor version97811e3Merge pull request #835 from JuliaSymbolics/as/no-esc-parsinge621b1efix: allow building non-esced expressions insym_from_parse_result06e650dMerge pull request #834 from JuliaSymbolics/as/easy-substituter72ece29feat: add one-argSubstituterconstructore6bafdabuild: bump patch versiondf5a35fMerge pull request #833 from JuliaSymbolics/as/ldiv-scalf4c168bfix: fix scalarization of\14025b7Merge pull request #832 from JuliaSymbolics/as/fix-unknown-shape-mul13f8167fix: fix edge case in multiplication of wrapped and unwrapped valueUpdates
ModelingToolkitto 11.4.0Release notes
Sourced from ModelingToolkit's releases.
Changelog
Sourced from ModelingToolkit's changelog.
... (truncated)
Commits
Updates
ModelingToolkitto 11.4.0Release notes
Sourced from ModelingToolkit's releases.
Changelog
Sourced from ModelingToolkit's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions