Add ReactantCore.jl for Reactant compilation support #784
+200
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds ReactantCore.jl as a dependency and introduces `@trace` macros to
data-dependent control flow throughout the solver libraries, enabling proper
compilation with Reactant.jl for XLA/GPU acceleration.
Changes:
- Add ReactantCore.jl dependency to NonlinearSolveBase and SimpleNonlinearSolve
- Add `@trace` macros to main solve loops and termination conditions in:
- NonlinearSolveBase/src/solve.jl
- NonlinearSolveBase/src/termination_conditions.jl
- All SimpleNonlinearSolve solvers (raphson, broyden, dfsane, halley,
klement, lbroyden, trust_region)
- Add Reactant to test dependencies
- Add Reactant AD tests for SimpleNewtonRaphson, SimpleBroyden, and NewtonRaphson
The `@trace` macro is required for data-dependent control flow (if/else, while,
for loops with data-dependent conditions) when compiling with Reactant to
ensure proper tracing through XLA.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
|
While this could technically work, I assume this is never how we'd want to do this here? @avik-pal . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@tracemacros to data-dependent control flow throughout the solver libraries, enabling proper compilation with Reactant.jl for XLA/GPU accelerationDetails
The
@tracemacro from ReactantCore.jl is required for data-dependent control flow (if/else, while, for loops with data-dependent conditions) when compiling with Reactant to ensure proper tracing through XLA.Files modified:
Dependencies:
lib/NonlinearSolveBase/Project.toml- Added ReactantCore dependencylib/SimpleNonlinearSolve/Project.toml- Added ReactantCore dependencyProject.toml- Added Reactant to test dependenciesCore solve logic:
lib/NonlinearSolveBase/src/NonlinearSolveBase.jl- Import@tracelib/NonlinearSolveBase/src/solve.jl- Added@traceto main solve loop and conditionalslib/NonlinearSolveBase/src/termination_conditions.jl- Added@traceto convergence checksSimpleNonlinearSolve solvers:
lib/SimpleNonlinearSolve/src/raphson.jllib/SimpleNonlinearSolve/src/broyden.jllib/SimpleNonlinearSolve/src/dfsane.jllib/SimpleNonlinearSolve/src/halley.jllib/SimpleNonlinearSolve/src/klement.jllib/SimpleNonlinearSolve/src/lbroyden.jllib/SimpleNonlinearSolve/src/trust_region.jlTests:
test/adjoint_tests.jl- Added Reactant AD tests using Enzyme Forward and Reverse modesTest plan
@jitcompilation🤖 Generated with Claude Code