fix: wire EIESN and AdditiveEIESN tests into CI#389
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Feb 9, 2026
Merged
fix: wire EIESN and AdditiveEIESN tests into CI#389ChrisRackauckas merged 1 commit intoSciML:masterfrom
ChrisRackauckas merged 1 commit intoSciML:masterfrom
Conversation
Four test files (test_eiesncell.jl, test_additiveeiesncell.jl, test_eiesn.jl, test_additiveeiesn.jl) existed on master but were never added to runtests.jl, so they were never run in CI. Also fix a bug in the no-bias test cases: the default `rand_sparse` initializer produces NaN on a 4×4 matrix due to zero spectral radius. Pass `init_reservoir = _W_I` since these tests only check for the absence of bias keys. Co-Authored-By: Chris Rackauckas <[email protected]> Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/runtests.jlthat were never included in the test runner:test/layers/test_eiesncell.jltest/layers/test_additiveeiesncell.jltest/models/test_eiesn.jltest/models/test_additiveeiesn.jlEIESNCellandAdditiveEIESNCell: the defaultrand_sparseinitializer produces NaN on a 4×4 reservoir matrix (too small for the default sparsity), causing test errors. Passinit_reservoir = _W_Isince these tests only verify absence of bias keys.These files and their source code were added in PRs #364 and #366 but the test runner was never updated to include them.
Test plan
GROUP=Core Pkg.test()passes locally (all 887 tests pass including new EIESN tests)GROUP=nopre Pkg.test()passes locally (13/13 QA tests pass)🤖 Generated with Claude Code