Restrict any and all` argument type bounds
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the argument types for the `any` and `all` methods
on tuples to not rely on julia base definining
`all(::Tuple{}) = true` and `any(::Tuple{}) = false`.
devmotion
reviewed
Mar 10, 2025
Co-authored-by: David Widmann <[email protected]>
oscardssmith
approved these changes
Mar 11, 2025
devmotion
reviewed
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #132.
Behavior does not change with the current Julia release, and the ambiguity is resolved for the nightly release.
Changes the argument types for the
anyandallmethods on tuples to not rely on julia base defininingall(::Tuple{}) = trueandany(::Tuple{}) = false.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This is not an issue with the current Julia release, but it likely will be in the future.