uniform comparison result type (Bool)
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following on from #23, change makes comparisons (`==`, `!=`, `<`, `<=`, `>`, `>=`) of two StaticBools return either `true` or `false` (which the other StaticTypes do under the same comparisons).
This tests StaticBool comparisons (`==`, `<`, `<=`) return Bool values, as do other StaticTypes when compared
restores StaticBool (`==`, `<`, `<=`) to yield Bool.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 7 7
Lines 429 429
=======================================
Hits 422 422
Misses 7 7
Continue to review full report at Codecov.
|
JeffreySarnoff
commented
Oct 23, 2021
| _lt(::False, ::True) = true | ||
| _lt(::True, ::True) = false | ||
| _lt(::False, ::False) = false | ||
| _lt(::True, ::False) = false |
There was a problem hiding this comment.
hmm .. experimenting
|
Sorry, deleted my comments (before seeing that you already responded) because I didn't realize julia> Static.lt(static(4),static(6))
static(true) |
chriselrod
approved these changes
Oct 23, 2021
|
@JeffreySarnoff, is this ready to merge? |
|
Yes. It does what it says it does. Nothing more. Nothing less. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #23,
this PR revises the comparison logic for
StaticBoolvalues so they result in aBoolvalue.This behavior matches the comparison logic for the other Static types.