Fix test failures in DDE and SDE tests #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was incorrectly assigning tspan to constant_lags instead of the actual constant_lags variable, causing test failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The non-diagonal noise test was referencing undefined parameter p. Since the functions don't use parameters, changed to pass nothing instead of the undefined p variable. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues Fixed
julia_assign("constant_lags", tspan)was incorrectly assigningtspaninstead ofconstant_lagspinSDEProblemcallChanges Made
tests/testthat/test_dde.R: Fixed variable assignment to use correctconstant_lagsvariabletests/testthat/test_sde.R: Changed undefined parameterptonothingsince functions don't use parametersTest plan
🤖 Generated with Claude Code