Update glossary.rst#6423
Closed
mg-lopez wants to merge 2 commits intoSciTools:mainfrom
mg-lopez:patch-1
Closed
Conversation
Really like the project, would love to contribute further. As mentioned in the docs, I read the user manual and edited the glossary to include expanded definitions and new terms that were not yet defined. 👍
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6423 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 90 90
Lines 23752 23752
Branches 4418 4418
=======================================
Hits 21331 21331
Misses 1672 1672
Partials 749 749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
From @SciTools/peloton. @mg-lopez sorry we missed your PR. We are very happy when new people are interested in contributing! We have a weekly meeting to manage community contributions, but unfortunately we didn't have it last week, which will happen from time to time. We did have a initial look at your PR and were excited by some of the changes. If you want to reopen this then we would be keen to review this and get it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really like the project, would love to contribute further. As mentioned in the docs, I read the user manual and edited the glossary to include expanded definitions and new terms that were not yet defined. 👍
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: