Add docs page on how to use S3 data.#6951
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6951 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 91 91
Lines 24886 24886
Branches 4672 4672
=======================================
Hits 22449 22449
Misses 1667 1667
Partials 770 770 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Hey @pp-mo
Generally this reads really well.
I have some small suggested changes.
The one issue I had though was that I could not install the s3-fuse package as detailed. I can see s3fs packages on pip and conda, but I think that these are not the fuse versions. This means I have not actually tested the instructions at this point.
There is a lot of ambiguity around the s3 packages it seems! If you can point me to the correct conda/pip package then I will test.
pp-mo
left a comment
There was a problem hiding this comment.
Sorry @ukmo-ccbunney I had a few suggestions of my own for your consideration,
which I apparently failed to post till now
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
OK - so the instructions work for me once I installed s3fs-fuse via conda.
However, see comments regarding pip/PyPI - you can't install it this way (it is not a python package).
|
Thanks @ukmo-ccbunney for comprehensive + diligent review ! I think I've now covered all the points raised so far, except what I commented about not giving any details of the credentials management : My thought there was that anyone using this would presumably have already dealt with that : Based on various earlier comments, I have tried to rationalise the use of bold "**" for names and code-format "``" for commands etc. Hope this now works for you but, again, open to discuss |
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Just a few things, then I think we're good!
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
|
Thanks @ukmo-ccbunney . |
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Great! Looking good. LGTM!
Thanks @ukmo-ccbunney ! |
Closes #6374