Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file paths, add file name, add empty directory check, update summary report #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix file paths, add file name, add empty directory check, update summary report #29

wants to merge 4 commits into from

Conversation

nathanhwangbo
Copy link

bib_reader.R

  • fixed bug in bib_reader where file wouldn't load because path wasn't specified

article_pdf_download.R

  • added titles to downloaded files in form "firstauthor_publicationyear_doi", with backslashes in doi doi replaced with ".."
  • added parameter overwrite to make sure that user is ok with overwriting outputfilepath
  • added is_empty column to the summary report to check if the downloaded files are empty, and moves the empty files to the non_pdfs folder.

@brunj7 brunj7 self-assigned this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brunj7 brunj7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanhwangbo @brunj7