Skip to content

Assigning group-specific permissions #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2025
Merged

Assigning group-specific permissions #84

merged 4 commits into from
Mar 27, 2025

Conversation

anondo1969
Copy link
Member

@anondo1969 anondo1969 self-assigned this Mar 25, 2025
@anondo1969 anondo1969 requested a review from alfredeen March 25, 2025 12:47
@anondo1969 anondo1969 marked this pull request as ready for review March 25, 2025 12:47
@anondo1969 anondo1969 requested a review from a team as a code owner March 25, 2025 12:47
alfredeen
alfredeen reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the Dockerfile. I see there are no automated tests for vscode in this repo. Could you look into adding some, even if quite basic?

@anondo1969 anondo1969 marked this pull request as draft March 27, 2025 12:08
@anondo1969 anondo1969 marked this pull request as ready for review March 27, 2025 13:11
@anondo1969 anondo1969 requested a review from alfredeen March 27, 2025 13:11
@anondo1969
Copy link
Member Author

Nice work on the Dockerfile. I see there are no automated tests for vscode in this repo. Could you look into adding some, even if quite basic?

I have added it. Thanks.

@anondo1969 anondo1969 requested a review from a team March 27, 2025 13:18
alfredeen
alfredeen approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for adding a test.

@anondo1969
Copy link
Member Author

lgtm. Thanks for adding a test.

Thank you.

@anondo1969 anondo1969 merged commit 38bf3ae into main Mar 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfredeen alfredeen alfredeen approved these changes

Assignees

@anondo1969 anondo1969

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anondo1969 @alfredeen