-
Notifications
You must be signed in to change notification settings - Fork 1
ss-1092 Reduce E2E workflow execution time #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
# Install Python packages with pip | ||
RUN pip install --no-cache-dir --upgrade pip \ | ||
&& pip install --no-cache-dir -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree that it's bad that poetry lock was regenerated on every image build, I think we should make it so that it's not regenerated every time, rather than go back to requirements.txt.
Plus I would argue for having a base dev image that has all the "cold" dependencies in it if we are doing these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a look at this run as a reference. It took 110s
https://github.com/ScilifelabDataCentre/serve/actions/runs/16216222707/job/45786179236
The most recent run on this branch took 66.8s
https://github.com/ScilifelabDataCentre/serve/actions/runs/16295304582/job/46015219258
In this run I've isolated poetry setup step from the actual dependencies installation step and updated poetry.lock
file for dependencies.
Poetry installation took 13.2s
Dependencies installation took 71.9s
Total 85s
https://github.com/ScilifelabDataCentre/serve/actions/runs/16350955458/job/46197322880
While it took more time, I think that dependencies are a bit behind and lock file wasn't updated in the repository and this resulted in it being regenerated in our latest CI jobs, which could be the the only explanation to the extra 25 seconds missing between the 1st and the 3rd runs.
On my local machine poetry update
take around 25s on this branch and results in an updated poetry.lock
file.
Description
Jira ticket: https://scilifelab.atlassian.net/browse/SS-1092
Doc: https://scilifelab.atlassian.net/wiki/x/HoDr3g
This PR includes several changes that can be done in the E2E workflow to speed up its execution time (as described in the doc). We don't have to adopt all of those changes, we can choose to adopt some of them.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!