Skip to content

feat(autoupdate): predefined hash case for GitHub #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(autoupdate): predefined hash case for GitHub #6416

wants to merge 3 commits into from

Conversation

WordlessEcho
Copy link

Description

  • Remove sha256: prefix in format_hash()
  • Add GitHub support in get_hash_for_app()

Motivation and Context

Close #6381

Use digests that automatically computed by GitHub.
Releases now expose digests for release assets - GitHub Changelog

Just like fosshub and sourceforge did: Special cases for FossHub and SourceForge - App Manifest Autoupdate · ScoopInstaller/Scoop Wiki

How Has This Been Tested?

(develop) $ .\bin\checkver.ps1 -Dir D:\apps\scoop\apps\peerbanhelper -u -f
manifest: 8.0.2 (scoop version is 8.0.2)
Forcing autoupdate!
Autoupdating manifest
Found: a6233a0f9c0f6d4fc37d9355177727f264be582b10cd54797f84b8801fd9f825 using Github Mode
Found: a6233a0f9c0f6d4fc37d9355177727f264be582b10cd54797f84b8801fd9f825 using Github Mode
Writing updated manifest manifest

PeerBanHelper is not merged yet. Manifest here: ScoopInstaller/Extras/pull/15764

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly. No, I don't have permission to edit wiki.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@o-l-a-v o-l-a-v mentioned this pull request Jul 12, 2025
Open
2 tasks
@WordlessEcho WordlessEcho deleted the branch ScoopInstaller:develop July 15, 2025 23:30
@WordlessEcho WordlessEcho deleted the develop branch July 15, 2025 23:30
@WordlessEcho WordlessEcho restored the develop branch July 15, 2025 23:31
@WordlessEcho WordlessEcho reopened this Jul 15, 2025
@nonperforming nonperforming mentioned this pull request Jul 18, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WordlessEcho