-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(autoupdate): Ensure GitHub API requests use token #6535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded conditional GitHub authentication to the autoupdate JSON-hash extraction: when a GitHub API URL is used and a token is present, the code now attaches an Authorization header and sets X-GitHub-Api-Version; changelog updated with the bug-fix entry. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)lib/autoupdate.ps1(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-31T01:48:00.222Z
Learnt from: z-Fng
Repo: ScoopInstaller/Scoop PR: 6471
File: CHANGELOG.md:9-9
Timestamp: 2025-08-31T01:48:00.222Z
Learning: The Scoop project's CHANGELOG.md follows a convention of tracking PR numbers only, not issue numbers, according to the maintainer z-Fng.
Applied to files:
CHANGELOG.md
🔇 Additional comments (1)
CHANGELOG.md (1)
14-14: LGTM! Changelog entry is correct.The entry properly documents the bug fix with the correct PR reference and follows the project's convention of tracking PR numbers only.
4069bc7 to
fe10b52
Compare
Motivation and Context
A patch for #6416. When retrieve hash from GitHub API, the token was not included in the request header.
Changes
refactor(autoupdate): Use a unified function interface to retrieve web content and cache the results.Edit: To keep things moving, I've split this change into another PR. This ensures the core updates stay small and get merged quickly, while the optimizations are handled in separate PR.
Related Issues/PRs:
How Has This Been Tested?
Tested on my own computer.
Checklist:
developbranch.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.